refactor(bthread): make TaskControl metric ownership explicit - #3490
Open
darion-yaphet wants to merge 1 commit into
Open
refactor(bthread): make TaskControl metric ownership explicit#3490darion-yaphet wants to merge 1 commit into
darion-yaphet wants to merge 1 commit into
Conversation
Per-tag bvar metrics and cumulative-time callback arguments were created with raw pointers, leaving destruction responsibilities unclear. Store them with unique_ptr while preserving metric names, access patterns, and scheduler behavior. Constraint: PassiveStatus does not own its callback argument Rejected: vector<CumulatedWithTagArgs> | reallocation can invalidate callback addresses Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep callback arguments alive until after their PassiveStatus is destroyed Tested: Rebuilt task_control.cpp CMake object target; git diff --check Not-tested: Full bthread tests are blocked by the existing EPROGREADTIMEOUT build error
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors bthread::TaskControl’s per-tag bvar metric bookkeeping to make ownership and lifetimes explicit, eliminating ambiguous raw-pointer ownership for metrics and callback arguments while preserving existing metric names and behavior.
Changes:
- Replace per-tag bvar raw-pointer vectors with
std::vector<std::unique_ptr<...>>members. - Introduce explicit ownership for
CumulatedWithTagArgsinstances used asPassiveStatuscallback arguments, keeping them alive for the lifetime of the correspondingPassiveStatus. - Update initialization to construct and wire per-tag metrics using
std::make_uniqueand.get()where a raw pointer is required by the bvar API.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bthread/task_control.h | Switches per-tag metric storage to unique_ptr and adds owned storage for callback arguments. |
| src/bthread/task_control.cpp | Updates TaskControl::init() to allocate per-tag metrics and callback args with explicit ownership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
TaskControl stored per-tag bvar metrics as raw pointers. In addition, each cumulative-time PassiveStatus received a heap-allocated callback argument with no explicit owner. Since PassiveStatus does not own that argument, its lifetime was unclear and could leak when TaskControl is destroyed.
What is changed and the side effects?
Changed:
Side effects:
———
Check List: